#9074: Expand latex support for combinatorial graphs via tkz-graph
-----------------------------+----------------------------------------------
Reporter: rbeezer | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.6
Component: graph theory | Keywords:
Author: Rob Beezer | Upstream: N/A
Reviewer: John Palmieri | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by jhpalmieri):
I'm not an expert in the tkz stuff, but the code looks okay to me, it
passes doctests, and the documentation looks very good: very good
descriptions of how to do things.
A few small issues in the file graph-latex.py:
- line 28: {{{the pre-builts styles}}}
- line 584: {{{controlling the rendering a graph}}} -- missing "of"
- line 609: {{{delegated to `dot2tex`}}} -- you should have double
backquotes around "dot2tex"
- line 716: {{{``vertex_label_color`` -- default: `black`}}} -- "black"
should be in ordinary quotes, not backquotes
- line 727: {{{``vertex_label_placement`` -- default: `center`}}} --
"center" should be in ordinary quotes, not backquotes
- line 1179: {{{positive number between and a copmpass point}}} --
missing words after "between", and "compass" is misspelled
This passes all tests on a machine with the tkz files, on a machine with
latex but without those files, and on a machine without latex. I tried
"sage -i graphviz", but the installation failed on my mac, so I couldn't
test the dot2tex parts.
For some of the argument error-checking, it might be nice in the future to
have some sort of conversion, so I could enter "E" or "e" instead of "EA"
for a direction, for instance. But that can go on another ticket.
Fix the typos, and it can have a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9074#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
