#9972: Add toric lattice morphisms
-------------------------------------+--------------------------------------
   Reporter:  novoselt               |       Owner:  mhampton  
       Type:  enhancement            |      Status:  needs_work
   Priority:  major                  |   Milestone:  sage-4.6  
  Component:  geometry               |    Keywords:            
     Author:  Andrey Novoseltsev     |    Upstream:  N/A       
   Reviewer:  Volker Braun           |      Merged:            
Work_issues:  switch to FanMorphism  |  
-------------------------------------+--------------------------------------

Comment(by vbraun):

 I couldn't figure out whether your patch goes before or after mine, so I
 folded it into one and fixed everything.

 I changed
 {{{
         # Optimization for fans generated by a single cone
         if len(cones) == 1:
             cone = cones[0]
             return RationalPolyhedralFan((tuple(range(cone.nrays())), ),
                                          cone.rays(), lattice,
                                          is_complete=lattice.dimension() >
 0)
 }}}
 to `is_complete=(lattice.dimension()==0)`.

 Now that we agree on this ;-) can you go ahead and remove the `Enhanced*`
 versions of fans and cones? Then we can go on with fan morphisms...

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9972#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to