#9972: Add toric lattice morphisms
-------------------------------------+--------------------------------------
Reporter: novoselt | Owner: mhampton
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.6
Component: geometry | Keywords:
Author: Andrey Novoseltsev | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: switch to FanMorphism |
-------------------------------------+--------------------------------------
Comment(by vbraun):
I don't want to rewrite the entire interface, and I think that having some
implicit assumption about what the `ambient()` is is usually fine. Also,
3.) is spectacularly ugly :-P As I said before, if the method call e.g.
returns again a collection of cones then you'll immediately notice that
you had the wrong `ambient()`. The difference with `ambient_ray_indices`
is that its output will fail in much more subtle ways if the hidden
assumption is wrong.
If you desperately want to keep `ambient_ray_indices()`, how about we
prefix any use in the toric varieties code with an assertion that makes it
explicit. This would be yet another way to make the implicit assumption
explicit and have it easily machine-verifiable.
On an unrelated note, I don't like `cone_of_fan = fan(cone)`, its too
similar to `Fan([cone])`. How about `Fan.cone_equivalent_to(cone)`, see
also the already-existing similar method `Fan.cone_containing(cone)`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9972#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
