#9210: pkg-config prefix statements in SAGE_LOCAL/lib/pkg-config not changed
upon
Sage move
-------------------------------------------------+--------------------------
Reporter: jason | Owner: drkirkby
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.6
Component: build | Keywords:
Author: Jason Grout | Upstream: N/A
Reviewer: David Kirkby, Karl-Dieter Crisman | Merged:
Work_issues: |
-------------------------------------------------+--------------------------
Comment(by jason):
Replying to [comment:37 kcrisman]:
> I had a long followup, but your reply explained things. So why can't we
also update those things? The new sage-location script
`update_pkgconfig_files` doesn't seem to touch anything but that
`SAGE_ROOT` guy, but it looks like there isn't any reason it couldn't, in
theory, do those prefix statements too and just make them
`${SAGE_ROOT}/local` or whatever is appropriate.
>
> (I'm going to try that change 'by hand' on freetype, by the way.)
I suppose the general problem is that we only know what the previous
`SAGE_ROOT` was (given in the sage-location.txt file). We don't know what
any other path in those pkgconfig files are, including the SAGE_ROOT from
the time before the last move.
I suppose we could be more invasive and always change the prefix path as
well. But there are other paths too. What paths do you change? In your
example, you had at least 3-4 paths from old build directories, and lots
of them are in things other than prefix statements. Which ones are old
`SAGE_ROOT`s, and which ones are still valid locations that shouldn't be
changed? For the ones that are old `SAGE_ROOT`s, which are the
`SAGE_ROOT` parts and which are the parts that shouldn't be changed?
The strategy now is to replace all SAGE_ROOT paths with the SAGE_ROOT
variable on the first startup, and then only change that in subsequent
runs if needed. That seems *much* safer.
Right now, the strategy breaks down for pkgconfig files created after the
initial build.
Another ticket should be created to update pkgconfig files that don't have
`SAGE_ROOT` already defined, which takes care of spkgs installed later.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9210#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
