#9651: Addition on CombinatorialFreeModule directly on dictionaries
-------------------------------+--------------------------------------------
Reporter: stumpc5 | Owner: sage-combinat
Type: enhancement | Status: positive_review
Priority: major | Milestone:
Component: combinatorics | Keywords: addition of dictionaries,
CombinatorialFreeModule
Author: Christian Stump | Upstream: N/A
Reviewer: Daniel Bump | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Changes (by bump):
* status: needs_review => positive_review
* reviewer: => Daniel Bump
Old description:
> At the moment, adding (and taking negative, substracting,...) for
> CombinatorialFreeModule is not done in a very efficient way.
>
> This patch
>
> - provides a cythonized version of a pointwise addition of dictionaries,
> together with multiple options
>
> - uses this addition of dictionaries to provide fast methods for
> CombinatorialFreeModule
>
> - is (indirectly) based on the patch in Ticket #9648
New description:
At the moment, adding (and taking negative, substracting,...) for
CombinatorialFreeModule is not done in a very efficient way.
This patch
- provides a cythonized version of a pointwise addition of dictionaries,
together with multiple options
- uses this addition of dictionaries to provide fast methods for
CombinatorialFreeModule
- is (indirectly) based on the patch in Ticket #9648
======================================
prerequisite:
trac_9648_modulemorphism_codomain_extension.2.patch
apply that patch and
trac_9651_CombinatorialFreeModule_Addition-cs.4.patch,
which supercedes the previously posted patches on this page.
--
Comment:
Positive review!
There is a thread about this patch in sage-combinat-devel
resulting in the latest version.
I tested this with sage-4.6.alpha3. After applying
{{{
trac_9648_modulemorphism_codomain_extension.2.patch
trac_9651_CombinatorialFreeModule_Addition-cs.4.patch
}}}
all tests pass. I also confirmed that the test is a speedup.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9651#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
