#10039: Make Parma Polyhedra Library a standard library
----------------------------+-----------------------------------------------
Reporter: vbraun | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-feature
Component: geometry | Keywords: ppl spkg
Author: Volker Braun | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by vbraun):
* status: new => needs_review
Comment:
I fixed the documentation according to your suggestions.
> 4. Why `affine_dimension` of the empty polyhedron is 0? Shouldn't it be
-1 to distinguish it from points?
The internal representation of dimensions is an unsigned int. So PPL
returns 0 instead of something negative. Using signed integer would half
the `max_space_dimension()` ;-)
> 5. Am I right that "concatenating" polyhedra means taking their
Cartesian product? Perhaps, it is a simpler explanation than in
`concatenate_assign`?
Yes. I just copy/pasted the C++ documentation. I've added a line that this
is the Cartesian product.
> 7. I don't understand what exactly is done by
`drop_some_non_integer_points`.
All that is guaranteed is that the result is non-strictly contained in the
original polyhedron and that integral vertices survive. Its not the most
useful function, but it is there and was easy to wrap ;-)
> 8. `frequency` does not have documentation.
I removed this one, it is only useful for grids (spanned lattices /
congruences).
> 9. Is it necessary to have `hash_code`, especially if it only returns
the dimension? My concern is that it can be confusing how it is related to
standard `hash` in Python, also it seems strange to use it for mutable
objects (again, because that's not how things work in Python). If this
function is not used anywhere, I would suggest removing it.
Removed.
> 10. I got upset when I read in the documentation of
`max_space_dimension` that it is bounded, but the doctest immediately made
me happy ;-)
Yes, should be enough for most applications ;)
> 11. `clear_mpz_globals`, `gmp_randrange`, `init_mpz_globals` have no
documentation.
I didn't define these, they were imported from `gmp.pxi` and sphinx adds
them to the documentation for some reason. Anyways, importing `gmp.pxi` is
not necessary so I removed it.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10039#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
