#9799: Running "make" in SAGE_ROOT returns the wrong exit code, leading to all
kinds of confusion
---------------------------------------------+------------------------------
Reporter: was | Owner: GeorgSWeber
Type: defect | Status: positive_review
Priority: critical | Milestone: sage-4.6
Component: build | Keywords: makefile
Author: Leif Leonhardy, John Palmieri | Upstream: N/A
Reviewer: Jeroen Demeyer | Merged:
Work_issues: |
---------------------------------------------+------------------------------
Description changed by jdemeyer:
Old description:
> This line in SAGE_ROOT/make
> {{{
> cd spkg && ./install all 2>&1 | tee -a ../install.log
> }}}
> will *always* return an exit status of 0, even if the build fails
> miserably. This leads to much confusion down the line, as explained in
> this sage-devel post:
>
> http://groups.google.com/group/sage-
> devel/browse_thread/thread/3487f96fda36b6f0/09be2d4dc50493f1#09be2d4dc50493f1
>
> The fix is probably to do what is described here:
>
> http://www.unix.com/shell-programming-scripting/92163-command-does-
> not-return-exit-status-due-tee.html
>
> As part of the patch, {{{makefile}}} should be renamed to {{{Makefile}}}
> (this is a more standard name).
New description:
This line in SAGE_ROOT/make
{{{
cd spkg && ./install all 2>&1 | tee -a ../install.log
}}}
will *always* return an exit status of 0, even if the build fails
miserably. This leads to much confusion down the line, as explained in
this sage-devel post:
http://groups.google.com/group/sage-
devel/browse_thread/thread/3487f96fda36b6f0/09be2d4dc50493f1#09be2d4dc50493f1
The fix is probably to do what is described here:
http://www.unix.com/shell-programming-scripting/92163-command-does-
not-return-exit-status-due-tee.html
As part of the patch, {{{makefile}}} should be renamed to {{{Makefile}}}
(this is a more standard name).
Follow-up tickets: #10156, #10157
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9799#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
