#10174: relative norm and trace in relative number fields are slow
-----------------------------+----------------------------------------------
Reporter: thome | Owner: davidloeffler
Type: defect | Status: needs_work
Priority: minor | Milestone:
Component: number fields | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by thome):
Replying to [comment:1 lftabera]:
> This will also improve the trace in the important case where the field
is the base field.
yes indeed.
> I think I would call self.base_ring() instead of
self.parent().base_field()
done
> I wonder if this can be further improved. For example if base equals
self.parent() the returning 1x1 matrix should be instantaneous (although
this is a very corner case).
indeed. I considered at first it wasn't worth the trouble, but it's so
ridiculously expensive that the 1-line additional diff is worth it, I
believe.
> Also, you need to add a doctest for the change.
Sure, done. However there's no difference in functionality beyond speed.
E.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10174#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
