#9655: Add an example plotting spherical harmonics to spherical_plot3d's
docstring
-----------------------------------------+----------------------------------
Reporter: olazo | Owner: olazo
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.6.1
Component: documentation | Keywords: spherical,harmonics
Author: Oscar Gerardo Lazo Arjona | Upstream: N/A
Reviewer: Minh Van Nguyen | Merged:
Work_issues: |
-----------------------------------------+----------------------------------
Comment(by olazo):
Replying to [comment:3 mvngu]:
> Here are some issues with olazo's patch:
>
> * The "User" should be filled with your real name and preferred contact
email address. I have fixed this in my update of olazo's patch; see
[attachment:trac-9655_spherical-harmonic-example.patch].
This is the first patch I produced using mecurial queues. At some point I
recieved a warning about User not being defined, but how do I set it up? I
mean other than directly editing the .patch
> * The code in olazo's patch does not conform to Python coding
conventions. In particular, see [http://www.python.org/dev/peps/pep-0008/
PEP 8]. This is fixed in my reviewer patch; see [attachment:trac-
9655_reviewer.patch]. Someone other than me needs to review that. If my
patch gets a positive review, the whole ticket gets a positive review.
I was unaware of such conventions...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9655#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
