#9418: Add GNU patch as a standard package.
----------------------------+-----------------------------------------------
Reporter: drkirkby | Owner: GeorgSWeber
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: build | Keywords: patch spkg
Author: David Kirkby | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by drkirkby):
Replying to [comment:12 jdemeyer]:
> David: instead of adding $(INST)/$(PATCH) as a dependency for every
package, would it not be better to do it on a "as-needed" basis? I mean
that, whenever a spkg gets upgraded to use {{{patch}}}, we add {{{PATCH}}}
as a dependency?
I do not think that would be a good idea. Every time someone wants to add
a patch, they would need to create one for 'deps' too. A lot of people
don't know how to use that file. Note even my initial comments I noted
there were several tickets touching 'deps' and these would need to be
coordinated. To make matters even more complicated, the 'deps' file is not
under revision control, which make s updating that file more problematic.
If the {{{patch}}} package took a long time to build, then I could see it
would slow the build of Sage, as it introduces a sometimes unnecessary
dependency. But for a package which takes less than 4 seconds to build
'''and''' run all the self tests, I think it is better to add it to 'deps'
now, so every package could use it now.
It also avoids the very real risk someone will create a patch, which will
work on their system since either
* patch has already benn built.
* There's a suitable version of patch on their system.
The patch would fail to install on another computer, because patch is not
built at that point in time. Since the order of building packages is not
fixed.
IMHO, {{{patch}}} should be built early, so it can be used with the
minimum amount of effort.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9418#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
