#10303: clean up sage-check-64 and use of SAGE64
-----------------------------+----------------------------------------------
Reporter: jhpalmieri | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.6.1
Component: build | Keywords: 64
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by leif):
Well, not [http://trac.sagemath.org/sage_trac/ticket/10138#comment:9 my
style]... ;-) (which is a bit more compact)
I wonder if the sanity check on `SAGE64`'s setting should be in `sage-
env`. (I assume it's still there, not visible in the patch.)
Nobody should call `sage-check-64` directly, but therefore I would
* test if `SAGE64` is either `yes`, `no` or empty '''there''' (otherwise
one could call / source it with e.g. `SAGE64=foo`),
* make sure that `SAGE_LOCAL` is defined,
* prevent running it directly by substituting
{{{
#!sh
#!/usr/bin/env bash
}}}
by
{{{
#!sh
#!/this/file/should/be/sourced
}}}
(and/or perhaps `chmod -x`).
I think we could drop "uname-specific" messages (and it's unlikely that
`SAGE64` will work on 32-bit hosts).
Note that `SAGE64=yes` is (currently) not supported (or doesn't make
sense) on anything but MacOS X and [Open]Solaris; this isn't clear from
the `echo` in `sage-env` (which is "commented out" IIRC, but people could
read it; also, ''"Creating SAGE_LOCAL/lib/sage-64.txt since it does not
exist."'' might be equally confusing to people building on e.g. 32-bit
Linux).
----
The name of the variable (and the "flag" file) is odd anyway (it should
IMHO be `SAGE_FORCE_64BIT_BUILD`), and there's [currently] no (analogous)
way to force a 32-bit build on systems that default to 64-bit...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10303#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
