#10303: clean up sage-check-64 and use of SAGE64
--------------------------------------------+-------------------------------
Reporter: jhpalmieri | Owner: GeorgSWeber
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-4.6.1
Component: build | Keywords: 64
Author: John Palmieri | Upstream: N/A
Reviewer: David Kirkby, Leif Leonhardy | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Comment(by leif):
Replying to [comment:32 jhpalmieri]:
> Replying to [comment:27 leif]:
> > Looks better, though I still don't like messing around with `SAGE64`
and the flag file at all on systems that don't use / require it. I
personally would make a distinction on the OS and, to not annoy some
developers, `SAGE_PORT` (i.e., only take care of `SAGE64` on MacOS X 10.4
and 10.5, Solaris and !OpenSolaris, or if `SAGE_PORT` is non-empty.
Allowing `SAGE64=ignore` would be another option, perhaps automatically
setting this on other platforms.)
>
> I didn't see any support on sage-devel to change the status quo which
allows the use of SAGE64 on any system, so I think for now, doing more
documenting of what's going on is the right choice.
Well, the status quo is (or was) to '''do nothing on any operating system
other than MacOS X or SunOS/Solaris'''. (I.e., `SAGE64` '''was'''
effectively ignored w.r.t. `sage-env` / `sage-check-64`. The assumption in
`spkg-install`s is that a non-empty `SAGE64` ''implies'' MacOS X or SunOS;
we previously had tests like `if [ "$SAGE64" = yes -a "$UNAME" = Darwin
]`, until Dave began to port to Solaris, first ''adding'' a test for
SunOS, then dropping the distinction on `$UNAME`, which as a side-effect
then slightly changed the meaning or possible interpretations of the
`spkg-install` files regarded in isolation. Of course removing the OS
dependency '''there''' makes sense, as long as the overall meaning is
kept.)
So this patch introduces quite different behavoir on the other platforms
rather than just removing stupid messages (and fixing the previous ill and
incomplete logic).
[[BR]]
> Yes, but you left out many of the comments and messages; for example,
your "# inconsistent -> error" replaced 15 lines of my version.
Shortening it that way doesn't count. ;)
I moved more detailed documentation to the Installation Guide... ;-)
My version also contains lots of (brief) comments and empty lines,
nevertheless fits on half a page, so is easier to read and maintain. (Dave
also likes saving a few bytes.) :D
The messages are a matter of taste; perhaps we should add more `--verbose`
and `--quiet` options (and/or corresponding enviro'''n'''ment variables)
to Sage.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10303#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
