#9940: Fix equality/inequality for AdditiveAbelianGroup
-----------------------------+----------------------------------------------
Reporter: mpatel | Owner: joyner
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-4.6.1
Component: group theory | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by jhpalmieri):
Replying to [comment:7 rbeezer]:
> So I am at a bit of a loss to understand what is broken in the non-
equality of G and H.
Me too.
> But still, a suggestion. Since equality is implemented in the
FGP_Module class, maybe the non-equality, as just the logical opposite,
should be implemented at the same level? In other words, use the same
logic as in the patch, but place it as
> {{{sage.modules.fg_pid.fgp_module.FGP_Module_class.__ne__}}}? Does that
make sense?
It sort of makes sense, and it seems to fix the nonequality problem, but
since nonequality already works for these modules, it doesn't seem
perfect. It also doesn't affect the problems with < and >:
{{{
sage: G=AdditiveAbelianGroup([0,0])
sage: H=AdditiveAbelianGroup([0,0])
sage: G < H
True
sage: H < G
False
}}}
I would really like to understand what's going on here. I won't be
completely happy with a patch until then, I think.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9940#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
