#9940: Fix equality/inequality for AdditiveAbelianGroup
-----------------------------+----------------------------------------------
Reporter: mpatel | Owner: joyner
Type: defect | Status: positive_review
Priority: critical | Milestone: sage-4.6.1
Component: group theory | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: Rob Beezer | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by rbeezer):
* status: needs_review => positive_review
* reviewer: => Rob Beezer
Comment:
I think implementing less-than, etc as submodule tests is the right way to
go as well.
Patch passes all long tests, and with the experimental package `chomp`
installed, patched version also passes:
{{{
sage -t -long -only-optional=chomp "devel/sage/sage/homology/tests.py"
}}}
I also installed the (in-progress) patch at #9773 which builds finitely-
generated groups on top of this module quotient code. Limited testing
indicates that (a) the current patch behaves as expected, and (b) the
comparison methods will apply properly to the subclasses.
Documentation looks good when previewed in the notebook (since it is not
included in the reference manual).
So: positive review. Thanks, John, for pursuing this one.
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9940#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
