#1956: implement multivariate power series arithmetic
-------------------------------------------+--------------------------------
Reporter: was | Owner: malb
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: commutative algebra | Keywords: multivariate power
series
Author: Niles Johnson | Upstream: N/A
Reviewer: Martin Albrecht, Simon King | Merged:
Work_issues: |
-------------------------------------------+--------------------------------
Changes (by niles):
* status: needs_work => needs_review
Old description:
> Multivariate power series arithmetic has been requested a *lot*.
>
> == Apply: ==
>
> 1. (unnecessary as of sage 4.6) patch from #9443
> 1. [attachment:trac_1956_multi_power_series_new_4.patch]
> 1. [attachment:trac_1956_uni_multi_ps_2.patch]
New description:
Multivariate power series arithmetic has been requested a *lot*.
== Apply: ==
1. (unnecessary as of sage 4.6) patch from #9443
1. [attachment:trac_1956_multi_power_series_new_4.patch]
1. [attachment:trac_1956_uni_multi_ps_2.patch]
1. [attachment:trac_1956_multi_ps_cleanup.patch]
--
Comment:
Thanks for the comments; these have been addressed now.
Replying to [comment:51 was]:
>
{{{
733 except TypeError,AttributeError:
}}}
> This should be
>
{{{
733 except (TypeError,AttributeError):
}}}
fixed.
> This scares me a little:
>
{{{
raise TypeError("action of "+c.parent()+" on "+f.parent()+" not
defined.")
}}}
> the reason is that any exception such that constructing a string as part
of it could take time, can potentially *MASSIVELY* slow down Sage. Just
do:
>
{{{
raise TypeError
}}}
> or
>
{{{
raise TypeError, "action not defined"
}}}
> instead.
This has been fixed, and I've checked every occurrence of "raise ..." for
similar problems (there are quite a few, since I've never heard of %debug,
or pdb, until now -- perhaps this would be a useful addition to the
developer's guide)
> I see this also
>
{{{
1062 except:
}}}
There were two naked excepts; in both cases the code has been rewritten to
avoid them.
> I also think that whenever possible all the inputs to a function should
be documented. For example look at this one ...
I've double-checked all functions now; the example you gave was one of the
toughest because I was modifying an existing function (from the
multivariate polynomial code). In any case, it's fixed now.
> I don't like all this "type(obj)==type" stuff. I think
isinstance(obj,type) is much better:
fixed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/1956#comment:55>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
