#10286: sage-native-execute does not unset path etc.
------------------------------+---------------------------------------------
Reporter: vbraun | Owner: jason
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.6.1
Component: misc | Keywords: sage-native-execute jmol
LD_LIBRARY_PATH original save restore sage-env
Author: Volker Braun | Upstream: N/A
Reviewer: Leif Leonhardy | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by leif):
Replying to [comment:3 leif]:
> [...]
> If we really use additional variables just to record if others were
already set (which is mostly superfluous), I would either use `true` or,
analogously to others, `"yes"`.
> [...] [[BR]]
> In `sage-env`, we could also use
{{{
#!sh
: ${SAGE_ORIG_PATH:=$PATH} # assign if not already set
# etc., and drop the *_SET variables
}}}
> (which may set `SAGE_ORIG_LD_LIBRARY_PATH` to Sage's modified, not the
original one in case it was empty and `sage-env` got sourced more than
once. But we should IMHO prevent the latter at the top of `sage-env` by
simply returning zero if e.g. `SAGE_ENV_SOURCED` is non-empty, otherwise
defining it to e.g. `"yes"`. This prevents other odd behavior as well.)
I've opened #10469 to address that (sourcing `sage-env` / saving the
original paths only once).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10286#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
