#10369: Yet another bug in factorization over number fields
-----------------------------------------+----------------------------------
   Reporter:  lftabera                   |       Owner:  tbd                    
     
       Type:  defect                     |      Status:  positive_review        
     
   Priority:  critical                   |   Milestone:  sage-4.6.2             
     
  Component:  factorization              |    Keywords:  factorization, number 
fields
     Author:  Jeroen Demeyer             |    Upstream:  N/A                    
     
   Reviewer:  Luis Felipe Tabera Alonso  |      Merged:                         
     
Work_issues:                             |  
-----------------------------------------+----------------------------------
Changes (by newvalueoldvalue):

  * status:  needs_review => positive_review
  * reviewer:  => Luis Felipe Tabera Alonso
  * author:  => Jeroen Demeyer


Comment:

 I confirm that the patch solves the problems mentioned for these cases and
 also some others I have found. With the latests versions of PARI we do not
 need to be so careful with non-monic polynomials. In the future we may
 consider eliminating the unit parameter from _factor_pari_helper. It is
 used right now in a few other places right now though.

 The patch also includes some documentation corrections.

 Depends on: #10430, #10279.

 Positive review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10369#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to