#2329: Add interface to PARI's rnfisnorm()
--------------------------------------------------------------+-------------
Reporter: craigcitro | Owner:
craigcitro
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-4.6.2
Component: number fields | Keywords:
editor_craigcitro
Author: Craig Citro, Marco Streng, Francis Clarke | Upstream:
N/A
Reviewer: Nick Alexander, David Loeffler, Jeroen Demeyer | Merged:
Work_issues: |
--------------------------------------------------------------+-------------
Changes (by newvalueoldvalue):
* status: needs_work => needs_review
* author: Craig Citro, Marco Streng => Craig Citro, Marco Streng,
Francis Clarke
Comment:
The patch `trac_2329_rnfisnorm4.patch` is a modified version of
`trac_2329_rnfisnorm3.patch`, designed to be applied after
1. #10430's
http://sage.math.washington.edu/home/jdemeyer/spkg/pari-2.4.3.alpha.p2.spkg;
1. #9390's `trac_9390-3rd_replacement.patch`.
The following changes have been made:
1. The workarounds to deal with the pari bugs have been removed.
1. The doctests to `sage.rings.number_field.number_field_element.is_norm`
involving non-Galois extensions have been changed. The first such example
was in fact a Galois extension (isomorphic to `CyclotomicField(9)`), which
without the patch to #9390 was asserted to be Galois by
`is_galois_relative`.
1. A minor change to `pari_rnfnorm_data` in `number_field.py` (replacing
`defining_polynomial` by `absolute_polynomial`) and more significant
changes to `rnfisnorm` in `number_field_element.pyx` to allow this
function to work with extensions L/K where K itself is a relative
extension. These are the changes I was referring to [comment:28 above].
Doctests have been added to illustrate this functionality.
1. Several spaces have been removed in order to comply more closely with
the style conventions given in the Developer's Guide, in particular:
"Don't use spaces around the '=' sign when used to indicate a keyword
argument or a default parameter value".
This all seems to work with 4.6.1.alpha3.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/2329#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
