#9713: Add toric Chow group
----------------------------------------------+-----------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.6.2
Component: algebraic geometry | Keywords:
Author: Volker Braun | Upstream: N/A
Reviewer: Andrey Novoseltsev, Simon King | Merged:
Work_issues: element class |
----------------------------------------------+-----------------------------
Changes (by SimonKing):
* status: needs_work => needs_review
Comment:
Hi Volker and Andrey!
Replying to [comment:38 vbraun]:
> I've renamed `element_class` -> `Element` as per Simon's comment,
thanks!
As I've pointed out in my previous post, one should ''define''
`self.Element`, but then the actual element class is `self.element_class`.
This is taken care of in my reviewer patch,
`trac_9713_fix_fg_pid_reviewer.patch`. Some doctests needed to be modified
accordingly. The reviewer patch also raises the doctest coverage of
`sage.modules.fg_pid` to 100% (some indirect tests had not been marked as
such).
> Maybe Simon would be interested in reviewing the first two patches
(`trac_9713_fix_cardinality.patch`, `trac_9713_fix_fg_pid.patch`) and
Andrey the ` trac_9713_toric_chow_group.patch`?
I give `trac_9713_fix_cardinality.patch` and `trac_9713_fix_fg_pid.patch`
(modulo my reviewer patch) a positive review. Of course, we all know that
it does not provide a full implementation of the new parent and coercion
model for modules; after all, that is not the purpose of this ticket. But
apparently it is enough for implementing the toric chow group. So, I
suggest to build a full implementation of coercion for modules on top of
these patches.
> Then we should make it into Sage-4.6.2...
My job is done. Andrey, your turn... :)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9713#comment:49>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
