#10573: notebook search tries to open a file which might not be created yet
------------------------------+---------------------------------------------
   Reporter:  rkirov          |       Owner:  jason, mpatel, was
       Type:  defect          |      Status:  needs_review      
   Priority:  minor           |   Milestone:                    
  Component:  notebook        |    Keywords:                    
     Author:  Radoslav Kirov  |    Upstream:  N/A               
   Reviewer:                  |      Merged:                    
Work_issues:                  |  
------------------------------+---------------------------------------------
Changes (by jthurber):

  * status:  new => needs_review


Comment:

 Should the status of this ticket be  "needs review"?

 I applied the patch with no problem on 4.6.1.rc1 and it seems to work
 fine.

 Without the patch I was receiving an
 """
 Internal Server Error
 An error occurred rendering the requested page. More information is
 available in the server log.
 """

 With the patch applied there was no error message, but there was a
 successful search.

 Comment: being relatively new to refereeing, I try to follow the
 guidelines in the Developer's guide.
 When I did the step:

 ./sage -coverage devel/sagenb/sagenb/notebook/worksheet.py

 the result was

 SCORE devel/sagenb/sagenb/notebook/worksheet.py: 37% (74 of 200)

 Conclusion?  The patch works, I will change status to positive review, but
 here is one sample .py file with modest coverage.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10573#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to