#10562: File ecpp.py added to sage: provides primality proving via Goldwasser-
Kilian and Atkin-Morain (ECPP)
--------------------------------+-------------------------------------------
Reporter: gh...@… | Owner: was
Type: enhancement | Status: needs_review
Priority: major | Milestone:
Component: number theory | Keywords: ecpp, goldwasser, kilian,
primality, proving
Author: Georg Hahn | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Comment(by robertwb):
Replying to [comment:4 gh...@…]:
> Thanks for all remarks!
>
> The file is now added to sage as .pyx file in the directory
devel/sage/sage/rings.
> The file SAGE_ROOT/devel/sage/module_list.py is updated by the patch.
>
> The new patch "trac_10562_ecpp.patch" now contains all the code (changes
in "sage/rings/all.py", "sage/module_list.py" and the new file
"sage/rings/ecpp.pyx" itself)
It doesn't look like you're using anything specific to Cython, any reason
why this isn't a simple .py file?
> [remark: in case I don't import all functions to the global namespace,
the error check ".\sage -t <path to file>" says that all those functions
which I haven't imported don't pass the error check any more !?]
You don't want to do a "from ecpp import *" as that will put every name in
your module into the global namespace--if everyone did this there would be
a very cluttered namespace not to mention thousands of collisions. For
testing anything but the top-level functions, you should have an explicit
"from sage.rings.ecpp import X" in your doctest before using it.
In terms of code organization, I think it would be better if a certificate
was a Python class with a verify method (that returned True or False), and
perhaps a nice __repr__ method as well.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10562#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
