#10562: File ecpp.py added to sage: provides primality proving via Goldwasser-
Kilian and Atkin-Morain (ECPP)
--------------------------------+-------------------------------------------
Reporter: gh...@… | Owner: was
Type: enhancement | Status: needs_work
Priority: major | Milestone:
Component: number theory | Keywords: ecpp, goldwasser, kilian,
primality, proving
Author: Georg Hahn | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Changes (by robertwb):
* status: new => needs_work
Comment:
Thanks. To add a file do "hg add" and then your patch can contain all the
code. Here's a couple of comments I have:
* I'm not sure that sage/functions is the best place for this. Probably
sage/rings (or perhaps there should be a subdirectory of that for number-
theoretic functions). sage/functions is for symbolic stuff.
* It probably doesn't make sense to import everything into the global
namespace--you probably should only import a couple of functions. Some
(e.g. verify_certificate) only have meaning in this specific context.
Also, for others (e.g. squarefree) it would make more sense (and would be
faster) to use the already available Integer.is_squarefree() function.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10562#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
