#5945: fastify factorization of inferior integers with flint
----------------------------------+-----------------------------------------
   Reporter:  boothby             |       Owner:  tbd         
       Type:  enhancement         |      Status:  needs_review
   Priority:  major               |   Milestone:  sage-4.6.1  
  Component:  factorization       |    Keywords:              
     Author:  boothby, spancratz  |    Upstream:  N/A         
   Reviewer:                      |      Merged:              
Work_issues:                      |  
----------------------------------+-----------------------------------------

Comment(by aapitzsch):

 You should use the variable {{{flint_depends}}} in '''module_list.py'''
 and
 {{{
 SAGE_LOCAL+'include/FLINT/'
 }}}
 or
 {{{
 SAGE_INC+'FLINT/'
 }}}
 instead of
 {{{
 SAGE_ROOT+'/local/include/FLINT/'
 }}}

 '''arith.py''':
 remove
 {{{
 if proof is None:
     proof = True
 }}}
 and let {{{n.factor}}} handle {{{proof=None}}}.

 '''integer.pyx''': I suggest using the global default for ''proof'' in
 factor()

 Change
 {{{
 F = [(Integer(f.p[i]), f.exp[i]) for i from 0 <= i < f.num]
 }}}
 to
 {{{
 F = [(Integer(f.p[i]), int(f.exp[i])) for i from 0 <= i < f.num]
 }}}
 then only following doctests fail (otherwise even more would fail, e.g.
 arith.py):
 {{{
 sage/misc/sageinspect.py
 sage/structure/factorization.py
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5945#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to