#10335: Add domains for permutation groups
-----------------------------+----------------------------------------------
Reporter: mhansen | Owner: joyner
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: group theory | Keywords:
Author: Mike Hansen | Upstream: N/A
Reviewer: Robert Miller | Merged:
Work_issues: needs rebase |
-----------------------------+----------------------------------------------
Changes (by rlm):
* reviewer: => Robert Miller
* work_issues: => needs rebase
Comment:
Applying to `sage-4.6.2.alpha0` on top of #10334, I get:
{{{
applying trac_10335-permgroup_domain-mh.patch
patching file sage/groups/perm_gps/permgroup.py
Hunk #5 FAILED at 321
1 out of 59 hunks FAILED -- saving rejects to file
sage/groups/perm_gps/permgroup.py.rej
patching file sage/groups/perm_gps/permgroup_named.py
Hunk #10 succeeded at 313 with fuzz 2 (offset 0 lines).
Hunk #11 succeeded at 315 with fuzz 1 (offset -49 lines).
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh trac_10335-permgroup_domain-
mh.patch
}}}
The failure:
{{{
$ cat sage/groups/perm_gps/permgroup.py.rej
--- permgroup.py
+++ permgroup.py
@@ -320,7 +322,7 @@
sage: G = PermutationGroup([[(1,2,3),(4,5)],[(3,4)]])
sage: TestSuite(G).run()
"""
- def __init__(self, gens=None, gap_group=None, canonicalize=True,
category = None):
+ def __init__(self, gens=None, gap_group=None, canonicalize=True,
category=None, domain=None):
r"""
INPUT:
}}}
Looks trivial to fix, and I'm excited to see this feature in Sage. Thank
you, Mike!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10335#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
