#2100: sensible defaults for aspect ratio
-------------------------------------------------------+--------------------
Reporter: jason | Owner: was
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
sage-4.6.2
Component: graphics | Keywords:
Author: Jason Grout, Karl-Dieter Crisman | Upstream: N/A
Reviewer: Andrey Novoseltsev, Karl-Dieter Crisman | Merged:
Work_issues: Plotting of vectors examples |
-------------------------------------------------------+--------------------
Comment(by kcrisman):
> > > These are the only errors on the whole library. I guess they should
be fixed in the same way as in the reviewer patch. Or maybe there should
be a better fix?..
> > No, that is the correct fix for now. An overarching ticket is
#10638, which I forgot to mention before.
Okay, now I am not rushing out the door and can think straight. The
problem is that this was never doctesting the thing in question in the
first place because of the issues raised in #10638.
I ''think'' the issue is that `_extract_kwds_for_show` keeps the
`@options` value of `aspect_ratio='auto') in play; when this gets passed
to the `show()` method of `Line` (which is what `line3d` creates in this
case), it refers to the one in `base.PrimitiveObject`, which unfortunately
then puts this value of `aspect_ratio` in:
{{{
opts = {}
opts.update(SHOW_DEFAULTS)
if self._extra_kwds is not None:
opts.update(self._extra_kwds)
opts.update(kwds)
}}}
and then doesn't realize it's a problem in
{{{
if opts['frame_aspect_ratio'] == 'automatic':
if opts['aspect_ratio'] != 'automatic':
# Set the aspect_ratio of the frame to be the same as that
of
# the object we are rendering given the aspect_ratio we'll
use
# for it.
opts['frame_aspect_ratio'] = \
self._determine_frame_aspect_ratio(opts['aspect_ratio'])
}}}
Which is where the problem happens.
Although fixing this in the vector plotting didn't seem to work
immediately.
Unless we wanted to change all the 'auto' in this patch to 'automatic'. I
don't know if that is desirable either, though. What do others think?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/2100#comment:40>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
