#10919: Addition of function ``is_uniform(k)`` for WordMorphism class
---------------------------------------+------------------------------------
Reporter: abmasse | Owner: abmasse
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.7
Component: combinatorics | Keywords:
Author: Alexandre Blondin Massé | Upstream: N/A
Reviewer: Sébastien Labbé | Merged:
Work_issues: |
---------------------------------------+------------------------------------
Changes (by abmasse):
* status: needs_review => positive_review
Comment:
Replying to [comment:3 slabbe]:
> I just uploaded a review patch which, I believe, improves the code.
>
> Other than that, documentation builds fine, all test pass, the new
function is OK. If you agree with my small fixes, you can change the
status of this ticket to positive review.
Hi, Sébastien !
Thank you for the review. Once again, you improved the efficiency of my
algorithm (I definitely need to be more careful about these small
optimisations).
I applied your patch over mine applied over sage-4.6.2 and all tests
passed, and the documentation built fine too. Of course, I agree with
them, so that I'm ready to set this ticket to positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10919#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
