#10752: Matrix pivots are cached, should be immutable
------------------------------+---------------------------------------------
Reporter: rbeezer | Owner: jason, was
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.7
Component: linear algebra | Keywords: matrix pivots
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by rbeezer):
Isolating changes at the cache-ing step is a great idea.
As an experiment, I changed all of the list() calls in the patch to
tuple(). Here are the observations. In sage/matrix only,
{{{
sage -t /dev/devel/sage-main/sage/matrix/matrix_cyclo_dense.pyx # 2
doctests failed
sage -t /dev/devel/sage-main/sage/matrix/matrix_integer_dense_hnf.py # 11
doctests failed
sage -t /dev/devel/sage-main/sage/matrix/matrix_modn_dense.pyx # 1
doctests failed
sage -t /dev/devel/sage-main/sage/matrix/strassen.pyx # 18 doctests
failed
sage -t /dev/devel/sage-main/sage/matrix/matrix_integer_dense.pyx # 15
doctests failed
sage -t /dev/devel/sage-main/sage/matrix/matrix0.pyx # 6 doctests failed
sage -t /dev/devel/sage-main/sage/matrix/matrix2.pyx # 48 doctests failed
sage -t /dev/devel/sage-main/sage/matrix/matrix_space.py # 1 doctests
failed
sage -t /dev/devel/sage-main/sage/matrix/matrix_modn_sparse.pyx # 2
doctests failed
}}}
About 17 of these end with:
{{{
File "/sage/dev/local/lib/python/site-
packages/sage/matrix/matrix_integer_dense_hnf.py", line 607, in
interleave_matrices
w = cols1 + cols2
TypeError: can only concatenate tuple (not "list") to tuple
}}}
and this looks like the only failures of this type. (I didn't know you
could concatenate two tuples.) Six, or so. are sorts of pivots, which
could be replaced by sorted(), I'd guess. The rest seem to be output
format (list versus tuple), or unrelated follow-on failures. So really, I
don't think it is that bad.
I'll look more closely in the morning.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10752#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
