#10837: Matrix and vector norms, condition number, over RDF/CDF
------------------------------+---------------------------------------------
Reporter: rbeezer | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.7
Component: linear algebra | Keywords:
Author: Rob Beezer | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by spice):
Hi Rob
All the tests pass muster, and the code checks out. A couple of cosmetic
issues:
1) Line 530 of sage/matrix/matrix_double_dense.pyx:
{{{
########################################################################
# LEVEL 3 functionality (Optional)
# * cdef _sub_
# * __deepcopy__
# * __invert__
# * Matrix windows -- only if you need strassen for that base
# * Other functions (list them here):
#
# compute_LU(self)
#
########################################################################
}}}
Perhaps list the methods here for ease of maintainance later on.
2) In your documentation on condition() and norm() you're missing an 'n'
in the word 'column' for the -Infinity norm case. Line 582 of
sage/matrix/matrix_double_dense.pyx:
{{{
- ``p = Infinity`` or ``p = oo``: the maximum row sum.
- ``p = -Infinity`` or ``p = -oo``: the minimum colum sum.
- ``p = 1``: the maximum column sum.
}}}
3) Line 705 of sage/matrix/matrix_double_dense.pyx:
{{{
if numpy is None:
import numpy
import sage.rings.infinity
import sage.rings.integer
import sage.rings.real_double
}}}
By convention, shouldn't import commands be listed at the top of a file?
4) The same again as above for the norm() code for matrices and vectors
you've added.
Simon
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10837#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
