#10837: Matrix and vector norms, condition number, over RDF/CDF
------------------------------+---------------------------------------------
Reporter: rbeezer | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.7
Component: linear algebra | Keywords:
Author: Rob Beezer | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Comment(by rbeezer):
Replying to [comment:13 spice]:
Hi Simon,
Thanks for the review. Responses below:
> 1) Line 530 of sage/matrix/matrix_double_dense.pyx:
<snip>
> Perhaps list the methods here for ease of maintainance later on.
Take a look at sage/matrix/docs.py. This stuff comes from there and is a
list of things you have to do in order for matrices to "work". So it
seems to be used as a check-list more than a list of what is available.
> 2) In your documentation on condition() and norm() you're missing an 'n'
in the word 'column' for the -Infinity norm case.
Good catch - I rolled this into a version 3 of the "edits" patch.
> 3) Line 705 of sage/matrix/matrix_double_dense.pyx:
> By convention, shouldn't import commands be listed at the top of a file?
> 4) The same again as above for the norm() code for matrices and vectors
you've added.
At the top of the file, then the import happens at start-up, which adds to
the (noticeable) delay. You can import anywhere, this is an attempt to
delay it until it is needed. `numpy` should be a variable, with module
scope, so the conditional will mean the import only happens once (but I
suspect it is not strictly necessary), which you will see throughout this
file in other methods.
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10837#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
