#10836: primitive root is broken
--------------------------------------------------+-------------------------
Reporter: kcrisman | Owner: was
Type: defect | Status: needs_info
Priority: critical | Milestone: sage-4.7
Component: number theory | Keywords:
Author: Karl-Dieter Crisman, William Stein | Upstream: Reported
upstream. Developers deny it's a bug.
Reviewer: William Stein, Karl-Dieter Crisman | Merged:
Work_issues: |
--------------------------------------------------+-------------------------
Changes (by newvalueoldvalue):
* status: needs_review => needs_info
* reviewer: => William Stein, Karl-Dieter Crisman
* author: Karl-Dieter Crisman => Karl-Dieter Crisman, William Stein
Comment:
Nice use of `is_prime_power` to make sure negatives don't get through.
Should we throw a better error message than
{{{
AttributeError: 'sage.rings.rational.Rational' object has no attribute
'is_prime_power'
}}}
for non-integer input? Or is it enough to say that there isn't a
primitive root? I guess same question for negatives. "No primitive root"
seems somewhat cryptic. Putting 'needs info'; I can also upload a
reviewer patch if you think that's okay. We would check for that
''after'' we actually got the primitive root, so it wouldn't slow anything
down.
Otherwise the patch looks good, and if William thinks `check=True` is good
enough, it's fine for me.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10836#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
