#8552: replace os.system calls in latex.py with appropriate replacements
-----------------------------+----------------------------------------------
Reporter: ddrake | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7
Component: misc | Keywords:
Author: Dan Drake | Upstream: N/A
Reviewer: John Palmieri | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by jhpalmieri):
* status: needs_work => needs_review
Old description:
> This is a followup to #8486, which uses {{{os.system('which xelatex')}}}
> to see if XeLaTeX is available. With #8474 now merged, we should use
> {{{have_program}}} to do that, and also replace other uses of
> {{{os.system}}} with appropriate {{{subprocess}}} replacements, since we
> are [http://docs.python.org/library/os.html#os.system supposed to use
> subprocess, and not os.system]
New description:
This is a followup to #8486, which uses {{{os.system('which xelatex')}}}
to see if XeLaTeX is available. With #8474 now merged, we should use
{{{have_program}}} to do that, and also replace other uses of
{{{os.system}}} with appropriate {{{subprocess}}} replacements, since we
are [http://docs.python.org/library/os.html#os.system supposed to use
subprocess, and not os.system]
-----
Apply only [attachment:trac_8552-all-in-one.patch].
--
Comment:
I'm attaching two new patches here. One is a referee patch, present for
review only: do not apply it. The other combines all of the patches into
one. Dan, if you're happy with my changes, please give this a positive
review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8552#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
