#10974: Overhaul matrix stack, augment
------------------------------+---------------------------------------------
Reporter: rbeezer | Owner: jason, was
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-4.7
Component: linear algebra | Keywords:
Author: Rob Beezer | Upstream: N/A
Reviewer: Keshav Kini | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by rbeezer):
* status: needs_work => positive_review
Old description:
> This patch overhauls, consolidates, fixes and expands matrix augmentation
> and stacking.
>
> Fixes:
> * subdivisions of matrices are generally not preserved under these
> operations, but now are
>
> Features:
> * a vector may now be supplied as a second argument across all routines
>
> Consolidation:
> * there is some standardization of variable names and techniques across
> the routines
>
> Expansion:
> * augment() for dense integer matrices is uncommented and working now
>
> Documentation:
> * new features (vector argument, subdivisions) have been documented
> where added
> * a general upgrade in documentation would be valuable, on another
> ticket
>
> To Do:
> * work to have result formed over a common ring
>
> "general" patch adds vector argument and subdivision support to the
> generic `stack()` method. Subdivision management is split out as helper
> methods for use with routines in the "special" patch.
>
> "special" patch works on routines for dense integer matrices, mod 2
> matrices, and generic sparse matrices. It also moves the generic matrix
> `augment()` to a better location in the source (it was left in place so
> changes could be seen more readily on the "general" patch).
>
> Apply: trac_10974_stack-augment-general.patch, trac_10974_stack-augment-
> special.patch, trac_10974_stack-augment.reviewer.patch
New description:
This patch overhauls, consolidates, fixes and expands matrix augmentation
and stacking.
Fixes:
* subdivisions of matrices are generally not preserved under these
operations, but now are
Features:
* a vector may now be supplied as a second argument across all routines
Consolidation:
* there is some standardization of variable names and techniques across
the routines
Expansion:
* augment() for dense integer matrices is uncommented and working now
Documentation:
* new features (vector argument, subdivisions) have been documented
where added
* a general upgrade in documentation would be valuable, on another
ticket
To Do:
* work to have result formed over a common ring
"general" patch adds vector argument and subdivision support to the
generic `stack()` method. Subdivision management is split out as helper
methods for use with routines in the "special" patch.
"special" patch works on routines for dense integer matrices, mod 2
matrices, and generic sparse matrices. It also moves the generic matrix
`augment()` to a better location in the source (it was left in place so
changes could be seen more readily on the "general" patch).
Apply: trac_10974_stack-augment-general.patch, trac_10974_stack-augment-
special.patch, trac_10974_stack-augment.reviewer-v2.patch
--
Comment:
Commit message fixed in v2 version of reviewer patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10974#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
