#10652: Add support for uploading static html doc page as a worksheet in the
notebook
--------------------------------------+-------------------------------------
Reporter: nthiery | Owner: nthiery
Type: enhancement | Status: needs_review
Priority: critical | Milestone: sage-4.7
Component: notebook | Keywords: days28, Sphinx, upload,
static html documentation
Author: Nicolas M. Thiéry, ... | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
--------------------------------------+-------------------------------------
Comment(by jason):
The code mainly looks okay to me, but here are a few points that worry me.
I haven't tested this, so this is not a full review (yet).
1. We of course don't want the notebook to crash if someone uploads a file
other than the right type. The assert statement in checking this worries
me. I'd say a ValueError would be appropriate (we got something that was
the wrong value).
2. In the _import_worksheet_html function, there is a return statement,
but then there are two more lines of code. What are those two lines doing
after the return statement?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10652#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
