#10652: Add support for uploading static html doc page as a worksheet in the
notebook
---------------------------------+------------------------------------------
   Reporter:  nthiery            |       Owner:  nthiery                        
                  
       Type:  enhancement        |      Status:  positive_review                
                  
   Priority:  critical           |   Milestone:  sage-4.7                       
                  
  Component:  notebook           |    Keywords:  days28, Sphinx, upload, static 
html documentation
     Author:  Nicolas M. Thiéry  |    Upstream:  N/A                            
                  
   Reviewer:  Jason Grout        |      Merged:                                 
                  
Work_issues:                     |  
---------------------------------+------------------------------------------
Changes (by newvalueoldvalue):

  * author:  Nicolas M. Thiéry, ... => Nicolas M. Thiéry


Comment:

 Replying to [comment:22 jason]:
 > nthiery: positive review on your patch, modulo the changes in my patch.
 Can you review my patch?
 >
 > Three substantial changes:
 >
 > 1. I changed the doctest to use a bit more of the actual generated
 documentation file structure.
 >
 > 2. I changed the linebreaks in the doctest so that the string "sage: "
 did not appear as consecutive characters in input (this works around the
 bug in the doctesting system which replaces "sage:" with ">>>")

 Ah ah! Good catch.

 > 3. I deleted the line which prepended the title and system to the text
 of the worksheet.  Those don't do anything but show up as the first part
 of the first text cell, which is silly.  The default system is already
 'sage', and the title is set when the worksheet is created.
 >
 > Can you review my reviewer patch?  If you think it's good, set this
 ticket to positive review.

 It's all good. Thanks much for the review (on behalf of the Sage Days 30
 participants)!

 Cheers,
                      Nicolas

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10652#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to