#6812: Enumerate integer vectors modulo to the action of a Permutation Group
-----------------------------+----------------------------------------------
   Reporter:  nborie         |       Owner:  nborie                             
           
       Type:  enhancement    |      Status:  needs_review                       
           
   Priority:  major          |   Milestone:  sage-4.7                           
           
  Component:  combinatorics  |    Keywords:  enumeration, integer, list, 
permutation, group
     Author:  Nicolas Borie  |    Upstream:  N/A                                
           
   Reviewer:                 |      Merged:                                     
           
Work_issues:                 |  
-----------------------------+----------------------------------------------
Changes (by nborie):

  * status:  needs_info => needs_review


Comment:

 For this last upload :

  * Cythonize the is_canonical test
  * Change syntax to have IntegerVectorsModPermgroup(G, sum=n) like
 IntegerVectors or other
  * Add a very heavy collection of tests in documentation for developers in
 the cython part

 I feel that my code is not very well polished, but I need advises,
 corrections and comments. Especially, I hope my English is not too much
 horrible. Flyspell is well configured on my emacs to american but I don't
 always use the right words. Sorry for that.

 Other things, I know the importance to have good tests in the code. But
 here, as the method `strong_generating_system` is very slow, test the
 module on any group take a very long time (around 3 seconds per group). I
 will be happy to get some advise and opinion on what deserve to be launch
 in doctest, what deserve to be kept in comment inside the code and what
 deserve to be trashed. Currently, the patch present a lot of tests in
 comments inside the code. It is perhaps too much (or the tests are not the
 goods one).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6812#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to