#10888: problem in evaluation dual isogeny
-----------------------------------------+----------------------------------
Reporter: wuthrich | Owner: cremona
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7
Component: elliptic curves | Keywords: isogenies,
Work_issues: | Upstream: N/A
Reviewer: Luca De Feo, John Cremona | Author: wuthrich
Merged: | Dependencies:
-----------------------------------------+----------------------------------
Changes (by cremona):
* cc: defeo (removed)
* reviewer: => Luca De Feo, John Cremona
* status: needs_work => positive_review
Comment:
I have also tested the patch and agree that it works (applied to
4.7.alpha5, all tests in elliptic curves pass).
I don't think that the test is too long. This whole file is quite long as
a whole (nearly 30s) but several other tests are longer! I expect to be
splitting this file into two before long, so I am happy to leave off the
"long time" tag. I would also be happy to have defeo's additional code
added.
It doesn't matter that this example does not appear in the reference
manual. It stays in as a test, to make sure this will continue to work in
future; but it does not add a lot to for the user, I think. If you want
it to appear in the manual, insert it in the header section of the file
(instead, or as well).
I'll set this to "positive review" now; if you (defeo) wants to make
further changes to the tests put it back to "needs review" and I'll look
at it again.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10888#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
