#11168: rubiks fails doctest with gcc 4.6.0 and -O2 optimisation.
---------------------------------------------------------------+------------
Reporter: drkirkby | Owner:
drkirkby
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-4.7
Component: solaris | Resolution:
Keywords: | Work_issues:
Upstream: Reported upstream. Developers acknowledge bug. | Reviewer:
John Palmieri
Author: David Kirkby, Jeroen Demeyer | Merged:
Dependencies: |
---------------------------------------------------------------+------------
Comment(by jdemeyer):
Replying to [comment:19 drkirkby]:
> Replying to [comment:18 jdemeyer]:
> > David, in principle I agree with your changes. However, the gcc
report indicates a problem with gcc/tree-ssa-loop-ivopts.c and because of
this it suffices to disable -fivopts. New spkg which does this (and also
simplifies the gcc version check):
> >
[http://boxen.math.washington.edu/home/jdemeyer/spkg/rubiks-20070912.p15.spkg]
>
> I think my test
>
> {{{
> if [ "x`$SAGE_LOCAL/bin/testcc.sh $CC`" = xGCC ] && [ "x`$CC
-dumpversion`" = x4.6.0 ] ; then
> }}}
>
> for the version is preferable. I can't see the point in calling a C
compiler with --version then greping the output, where there is a
documented option (-dumpversion) to show just the version,
>
> Also, this could well fail for another compiler with a version of 4.6.0
- I think its safer to test for gcc first.
My test ''does'' test for gcc in the {{{--version}}} output.
If I change the gcc test to use your original test code, would the rest of
my patch get positive_review?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11168#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
