#11168: rubiks fails doctest with gcc 4.6.0 and -O2 optimisation.
---------------------------------------------------------------+------------
Reporter: drkirkby | Owner:
drkirkby
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-4.7
Component: solaris | Resolution:
Keywords: | Work_issues:
Upstream: Reported upstream. Developers acknowledge bug. | Reviewer:
John Palmieri
Author: David Kirkby, Jeroen Demeyer | Merged:
Dependencies: |
---------------------------------------------------------------+------------
Comment(by drkirkby):
Replying to [comment:21 jdemeyer]:
> David, another minor issue with your test:
> I would change {{{[ "x`$CC -dumpversion`" = x4.6.0 ]}}} to {{{[ "x`$CC
-dumpversion 2>/dev/null`" = x4.6.0 ]}}} in case that `$CC` does not
support `-dumpversion`.
I need to be doing something else now (gardening), so don't have chance to
do much with this, but a few quick notes.
* My machine is rather busy now, doing a scrub of the disks (Google scrub
and ZFS if you want). The test took 130.9 seconds, compared to the 26.7
seconds with just -O1. That's slowed down by a factor of almost 5. Perhaps
the load on my machine has caused this, but can you check this option has
not slowed things significantly. If it slower than -O1, then I think it
would be better to revert to -O1.
* My test does not use the -dumpversion option unless the compiler is
first confirmed to be gcc, since the second part of the test (the version)
will not be executed unless the first part (the type of compiler), is
confirmed to be GCC. So I don't really see the need to send stderr to
/dev/null, but I'm not bothered about that fact.
* A very minor point, but it would be worth putting a link to the gcc bug
in SPKG.txt.
Assuming you can confirm the new compiler option given does not cause a
dramatic slowdown, and change the test, then feel free to change the
ticket to positive review - don't wait for me. Issues about SPKG.txt and
/dev/null are not too critical - make what changes you feel are
appropriate.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11168#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
