#11220: implement listing j-invariants of CM curves over other fields and fix
incorrect remark in the documentation
-------------------------------+--------------------------------------------
Reporter: was | Owner: cremona
Type: enhancement | Status: needs_info
Priority: minor | Milestone: sage-4.7.1
Component: elliptic curves | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: John Cremona
Merged: | Dependencies:
-------------------------------+--------------------------------------------
Changes (by robertwb):
* status: needs_review => needs_info
Comment:
The implementation of cm_j_invariants_and_orders looks wrong to me--you
seem to be listing/zipping every D rather than only the ones corresponding
to the j's found when the Hilbert polynomial is reducible.
As a side note there seems to be a lot of duplication between the two
functions--given that cm_j_invariants_and_orders is just about a cheap,
I'd just invoke that and strip off the part you want for cm_j_invariants.
Also, I think the code might be cleaner if you make an inner function {{{d
-> (D, f, j)}}} and then do {{{[func(d) for d in dlist]}}} (or the
concatenation, if there are 0-2 results for every d) rather than
expressing things as a series of list comprehensions with adjustments here
and there.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11220#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
