#11220: implement listing j-invariants of CM curves over other fields and fix
incorrect remark in the documentation
-------------------------------+--------------------------------------------
   Reporter:  was              |          Owner:  cremona        
       Type:  enhancement      |         Status:  positive_review
   Priority:  minor            |      Milestone:  sage-4.7.1     
  Component:  elliptic curves  |       Keywords:                 
Work_issues:                   |       Upstream:  N/A            
   Reviewer:                   |         Author:  John Cremona   
     Merged:                   |   Dependencies:                 
-------------------------------+--------------------------------------------
Changes (by was):

  * status:  needs_review => positive_review


Comment:

 I read the patches and I think this is now good.  When reading, I missed
 Cremona's comment on this ticket, which made it harder to read the code,
 so I added his argument as a comment in the code.  Otherwise, I changed
 nothing, except flattening the patches and making the authors both John
 and Robert.

 Positive review (imho).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11220#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to