#11243: python spkg build fails on Ubuntu 11.04
-------------------------------------------------------------+--------------
Reporter: pipedream | Owner:
Type: defect | Status:
needs_review
Priority: blocker | Milestone:
sage-4.7
Component: build | Resolution:
Keywords: | Work_issues:
Upstream: None of the above - read trac for reasoning. | Reviewer:
David Kirkby, Jan Groenewald, Dan Drake
Author: Jan Groenewald, David Kirkby | Merged:
Dependencies: |
-------------------------------------------------------------+--------------
Comment(by drkirkby):
I'm not sure why you have switched from using "{{{lsb_release}}}" to
greping {{{/etc/issue}}}. It seems that "{{{lsb_release}}}" is a common
command on most (all?) Linux systems, so the fact it works on your
system's bash shell, but not in your Sage subshell, probably tells you the
subshell or your test is broken. Why not fix that, rather than use another
method?
As a general point, I would avoid the use of '-e' to test a file, as it's
not portable. In this case it does not matter as the bash shell is
invoked, but it would fail if you used a Bourne shell, so had:
{{{
#!/bin/sh
}}}
at the top.
From the man page on a Solaris system:
{{{
-e file True if file exists. (Not avail-
able in sh.)
}}}
Using '-f' is much safer as it will be found on far more shells.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11243#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
