#11243: python spkg build fails on Ubuntu 11.04
-------------------------------------------------------------+--------------
Reporter: pipedream | Owner:
Type: defect | Status:
needs_work
Priority: blocker | Milestone:
sage-4.7
Component: build | Resolution:
Keywords: | Work_issues:
Upstream: None of the above - read trac for reasoning. | Reviewer:
David Kirkby, Jan Groenewald, Dan Drake
Author: Jan Groenewald, David Kirkby | Merged:
Dependencies: |
-------------------------------------------------------------+--------------
Changes (by drkirkby):
* status: needs_review => needs_work
Comment:
The error checking you added is not working correctly.
I tested this first on my !OpenSolaris system - it worked OK.
Then I spoofed my machine to appear if it was Ubuntu 11.04. Your patch
detected that, patched the python package, then it built OK. (Really
whether it built or not was pretty irrelevant here, as I'd applied a Linux
patch on Solaris).
Next as a test I corrupted the patch. When I try to install it, now I see:
{{{
Ubuntu 11.04
Patching src/Modules/Setup.dist as this is Ubuntu 11.04
patch: **** Only garbage was found in the patch input.
Error patching Setup.dist
Applying a revised 'configure' script for Solaris
See http://bugs.python.org/issue1759169
http://trac.sagemath.org/sage_trac/ticket/7867
Setting HAVE_FD_TRANSFER=0 for Solaris to allow
the python module '_multiprocessing' to build
See: http://trac.sagemath.org/sage_trac/ticket/8440
checking for --with-universal-archs... 32-bit
}}}
In other words, despite the fact that Patch has reported the patch as
garbage, the build just continues. So the error checking is not working
correctly.
The man page for '{{{patch}}}' says the exit code is 0 in the case of no
error.
There is one other issue too, which is partially my fault. When I copied
over the file you had corrupted, the time stamp on the directory has been
changed. So it looks like the contents of {{src/Modules}}}' have been
modified, even though they have not. It would be more sensible to copy the
contents exactly, retaining all dates and times, so it does not leave
anyone in any doubt the contents are unmodified.
I sometimes wonder if the files below the 'src' directory should be made
read-only. That would stop accidentally changing them.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11243#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
