#10912: add order setters and Tate and ate pairings
-------------------------------+--------------------------------------------
   Reporter:  mariah           |          Owner:  cremona                 
       Type:  enhancement      |         Status:  positive_review         
   Priority:  major            |      Milestone:  sage-4.7                
  Component:  elliptic curves  |       Keywords:                          
Work_issues:                   |       Upstream:  N/A                     
   Reviewer:                   |         Author:  Mariah Lenox, Aly Deines
     Merged:                   |   Dependencies:                          
-------------------------------+--------------------------------------------
Changes (by cremona):

  * status:  needs_review => positive_review


Old description:

> add order setters and Tate and ate pairings
>
> '''Apply:'''
>
> 1. Apply [attachment:Trac10912.patch]

New description:

 add order setters and Tate and ate pairings

 '''Apply:'''

 1. Apply [attachment:trac_10912-ate.patch]

--

Comment:

 Looks fine to me, and all tests in elliptic)curves pass.  Very nice job
 with excellent tests and examples.

 My patch replaces the previous ones;  it just corrected a couple of minor
 typos in the docstrings.

 Positive review!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10912#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to