#11287: Interface to runsnake and import_statements
------------------------------------------+---------------------------------
   Reporter:  nthiery                     |          Owner:  tbd                
              
       Type:  enhancement                 |         Status:  needs_review       
              
   Priority:  major                       |      Milestone:  sage-4.7.1         
              
  Component:  performance                 |       Keywords:  runsnake, prun, 
profiling, days30
Work_issues:                              |       Upstream:  N/A                
              
   Reviewer:  Franco Saliola, Simon King  |         Author:  Nicolas M. ThiƩry  
              
     Merged:                              |   Dependencies:                     
              
------------------------------------------+---------------------------------

Comment(by nthiery):

 Replying to [comment:6 saliola]:
 > Hello! I just posted a reviewer's patch that addresses some
 documentation
 > issues. The docstrings for the Profiler module needed to be fixed so
 that they
 > rendered correctly in the reference manual.
 > ...
 > I am willing to give this a positive review, provided my changes are
 > acceptable.

 Positive review on your review patch, assuming the buildbot goes green.

 > > I would recommend to use the tools from sage.misc.sageinspect, but
 only after applying #9976, which considerably extends the capabilities of
 finding source files (here:
 sage/rings/polynomial/multi_polynomial_libsingular.pyx), from which one
 can deduce the import statement.
 >
 > Perhaps this might be a good idea and can address the issue that the
 > `__module__` attribute is not always present. I'll leave it to
 > Nicolas to comment on this.

 If you know how to improve this on top of your head, please go ahead!
 Otherwise, I'll vote for just pushing this as is, and fix it later. It
 is annoying if this method is not robust, but not dangerous, and we
 want to let it be used to get feedback.

 Cheers,
                         Nicolas

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11287#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to