#11302: Make it easier to construct a fan from a triangulation
----------------------------------+-----------------------------------------
   Reporter:  vbraun              |          Owner:  mhampton       
       Type:  enhancement         |         Status:  positive_review
   Priority:  major               |      Milestone:  sage-4.7.1     
  Component:  geometry            |       Keywords:                 
Work_issues:                      |       Upstream:  N/A            
   Reviewer:  Andrey Novoseltsev  |         Author:  Volker Braun   
     Merged:                      |   Dependencies:                 
----------------------------------+-----------------------------------------
Changes (by vbraun):

  * status:  needs_review => positive_review


Old description:

> A common step in toric geometry is to construct the fan from some
> triangulation. This patch adds a `fan()` method to the triangulation
> class, so you can write:
> {{{
> sage: pc = PointConfiguration([(0,0), (1,0), (0,1), (-1,-1)], star=0,
> fine=True)
> sage: triangulation = pc.triangulate()
> sage: fan = triangulation.fan(); fan
> Rational polyhedral fan in 2-d lattice N
> sage: fan.is_equivalent( toric_varieties.P2().fan() )
> True
> }}}

New description:

 A common step in toric geometry is to construct the fan from some
 triangulation. This patch adds a `fan()` method to the triangulation
 class, so you can write:
 {{{
 sage: pc = PointConfiguration([(0,0), (1,0), (0,1), (-1,-1)], star=0,
 fine=True)
 sage: triangulation = pc.triangulate()
 sage: fan = triangulation.fan(); fan
 Rational polyhedral fan in 2-d lattice N
 sage: fan.is_equivalent( toric_varieties.P2().fan() )
 True
 }}}

 Apply:
   * [attachment:trac_11302_fan_of_a_triangulation.patch]
   * [attachment:trac_11302_reviewer.patch]

--

Comment:

 Oops I added the `p.set_engine('internal')` to the doctests at the end but
 then forgot to check that they work. Thanks for catching it :-)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11302#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to