#9759: Addition of SI prefixes capabilities to the units module
---------------------------+------------------------------------------------
Reporter: cousteau | Owner: burcin
Type: enhancement | Status: needs_review
Priority: trivial | Milestone: sage-4.7.1
Component: symbolics | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Javier Mora
Merged: | Dependencies:
---------------------------+------------------------------------------------
Changes (by burcin):
* milestone: => sage-4.7.1
Comment:
The patch looks good to me. It is a hack and I am not really happy with
the use of `sage_eval()`, but this seems to be used everywhere in
`sage/symbolic/units.py`. I'm ready to give a positive review, though it
would be better if somebody who actually uses this module comments on the
improvement.
Why does the new function name start with an underscore? Wouldn't it be
easier to find it if was just named `si_prefix()`?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9759#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
