#11255: Enhance the e_one_star.Patch class
-----------------------------+----------------------------------------------
Reporter: tjolivet | Owner: sage-combinat
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.7.1
Component: combinatorics | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Timo Jolivet
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by tjolivet):
Hi, thanks for you corrections and your patch.
> I still have concerns with two things before giving a positive review :
(1) I think the method {{{Patch.__getitem__}}} should be removed as the
result can be different on other machine and (2) the ordering of the iter
method of a Patch is not guarenteed. So the result of the tikz method may
change on other machine which may lead to doctest problem later. So I
suggest not to change the tikz method, but rather change the way we test
them.
I would like to keep the {{{__getitem__}}} method because we use it often
when we need to pick an arbitrary face of a patch. But we should in this
case write a WARNING in the doc, I agree that the result changing from
machine to machine can be confusing.
I will soon make the changes to the doc to prevent the {{{__iter__}}}
ordering problems. (Should be easy by comparing strings or by using
{{{__sorted__}}}. How do you think should the tikz output be tested to
prevent these problems?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11255#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
