#11255: Enhance the e_one_star.Patch class
-----------------------------+----------------------------------------------
Reporter: tjolivet | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: combinatorics | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Timo Jolivet
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by slabbe):
I just upload a patch which applies over all the precedent ones. The
positive
review is near. Again, I have one question about the methods
`faces_of_vector`, `faces_of_type`:
{{{
#!diff
- return [face for face in self if face.vector() == vector(v)]
+ return [Face(f.vector(), f.type(), f.color()) for f in self if
f.vector() == vector(v)]
}}}
{{{
#!diff
- return [face for face in self if face.type() == t]
+ return [Face(f.vector(), f.type(), f.color()) for f in self if
f.type() == t]
}}}
Why do we need copies in those cases?
Sébastien
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11255#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
