#7794: PolynomialRing_integral_domain ignores Ctrl-C and segfaults
--------------------------+-------------------------------------------------
Reporter: SimonKing | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-4.7.1
Component: algebra | Keywords: Polynomial Ring KeyboardInterrupt
Work_issues: | Upstream: N/A
Reviewer: Simon King | Author: Jeroen Demeyer
Merged: | Dependencies:
--------------------------+-------------------------------------------------
Comment(by SimonKing):
All long tests passed with your new patch.
I tried to add a doc test, as follows:
{{{
sage: def test():
... P = GF(3)['T']
... PP = P['z']
... T = P.gen()
... z = PP.gen()
... alarm(1)
... try:
... while(1):
... x = (z**3+T*z)**243
... except KeyboardInterrupt:
... print "First interrupt caught"
... alarm(1)
... try:
... while(1):
... x = (z**3+T*z)**243
... except KeyboardInterrupt:
... print "Second interrupt caught"
sage: test()
First interrupt caught
Second interrupt caught
}}}
However, it did not work, since there seem to be other places in which
errors are not properly caught. Namely, I occasionally got:
{{{
sage: test()
First interrupt caught
Exception KeyboardInterrupt: KeyboardInterrupt('computation timed out
because alarm was set for 1 seconds',) in T^79 + 2*T^78 + 2*T^77 + T^74
ignored
^CSecond interrupt caught
}}}
So, the first alarm worked, but the second didn't, and only when I pressed
<ctrl>-c then the computation was interrupted.
What shall we do now? Clearly, your patch is a progress. So, I tend to
give it a positive review (because all tests pass), and deal with the
remaining problem on a different ticket.
What do you think?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7794#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.