#11255: Enhance the e_one_star.Patch class
-------------------------------+--------------------------------------------
Reporter: tjolivet | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: combinatorics | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Sébastien Labbé | Author: Timo Jolivet
Merged: | Dependencies:
-------------------------------+--------------------------------------------
Changes (by tjolivet):
* owner: sage-combinat =>
Comment:
Replying to [comment:24 slabbe]:
> What if the user wants to get the faces of a certain type and does not
want to repaint them? We do useless copies in that case. I feel like those
methods should return the faces as they are. I think the user may make the
copies himself.
>
> It is like if the patch was a Python set. Iterating through it iterates
through its elements (not copies of them).
OK, I agree. If {{{Patch.__iter__}}} doesn't return new copies then
{{{Patch.faces_of_truc}}} should behave the same. (And some user might
also want to change the colors of the faces of given vector or type.)
Oh, I think we should also add a method {{{Patch.faces_of_color}}}. We
just have to be careful about the input: we must convert it in the same
way as we convert face colors, and we must take into account that color
comparison is python is a bit strange:
{{{
sage: a = Color('red')
sage: b = Color('red')
sage: a == b
False
sage : tuple(a) == tuple(b)
True
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11255#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
